Use HttpClient instead of HttpWebRequest

[johanneszab]

The code is full with error prone exception handling caused by the HttpWebRequest api. Additionally the async variant of the GetReposone method, GetResponseAsync() is broken as it never timeouts if the underlying connection drops and lead me to implement the TaskTimeout Extension.

From the MSDN docs (the GetResponeAsync() method uses BeginGetResponse() internally (thanks for not telling MS!)):

The Timeout property has no effect on asynchronous requests made with the BeginGetResponse or BeginGetRequestStream method.

The newer interface HttpClient was designed with async in mind and should be used instead. It also doesn't use Exceptions to handle non-successful web responses (i.e. status codes 300-499).

See also these issues for more: TumblThree/#116, TumblThree/#214.

[yfdyh000]

Work in progress, but now blocked in make globalized HttpClient and cookieContainer, because I am not a C# expert.
My goal is HTTP/2.

See yfdyh000@6ca9537. Help wanted.

New efforts are underway.

[yfdyh000]

https://github.com/yfdyh000/TumblThree/tree/httpClient-wip1 (still going on locally)
My work, now it seems to work, but a lot of exceptions handling needs to be rewritten, as well as testing and repairing, this is a big project...
Peers still care about this?

[thomas694]

Thanks for your work!
Sadly, after over one year after the issue had been opened, no one still monitored it and saw your efforts. I don't expect that you are still encouraged. So maybe when I have enough time, I'll make a copy of your branch and try to update it to the latest code version to see how it fits and can be used as a good starting point for further continuation.

[yfdyh000]

Thanks for your work!
Sadly, after over one year after the issue had been opened, no one still monitored it and saw your efforts. I don't expect that you are still encouraged. So maybe when I have enough time, I'll make a copy of your branch and try to update it to the latest code version to see how it fits and can be used as a good starting point for further continuation.

Thank you for your answer. I have suspended work on it.

[thomas694]

Let me know, also later, if you like to resume. If not, it's understandable.