Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Conversions] Adding more currencies to the conversion cog/plugin #223

Open
Cabbidachi opened this issue Mar 20, 2021 · 1 comment
Open

Comments

@Cabbidachi
Copy link

Cabbidachi commented Mar 20, 2021

So the conversions cog has this function to convert currencies from one to another. The thing is that i recently noticed it for example doesn't have ARS (Argentina Pesos). I would find it very helpful if it has that currency at one point since i have a friend in Argentina. Besides that addding more currencies to the cog in general would be very neat but isn't specifically needed, since the cog already has a bunch of common currencies like EUR, USD, GBP etc.
Rather take it as a recommendation :3.

@Cabbidachi Cabbidachi changed the title Adding more currencies to the conversion cog/plugin [Conversions] Adding more currencies to the conversion cog/plugin Mar 20, 2021
@Nanako0129
Copy link

I tried TRY (Turkish lira) and it shows, "The currencies provided are not valid!"
I found the code, it use API from https://query1.finance.yahoo.com which provides the currency price data.

url = f"https://query1.finance.yahoo.com/v8/finance/chart/{currency1}{currency2}=x"

So I think some currency information is missing in their database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants