Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disabling consul #551

Open
geek opened this issue Feb 27, 2018 · 5 comments
Open

Support disabling consul #551

geek opened this issue Feb 27, 2018 · 5 comments
Labels

Comments

@geek
Copy link
Contributor

geek commented Feb 27, 2018

Allow ContainerPilot to execute and startup jobs, even jobs that register ports and have health checks, without consul. If the consul configuration is set to false then consul is being disabled. When this occurs the jobs should still be initialized but there shouldn't be attempts to register the jobs/services with consul. Similarly, there shouldn't be support for consul watches. If watches are in use with consul: false then there should be an error. There are likely other edge cases too, but I do think this is possible and a valid use case for ContainerPilot to act as an init process without requiring consul.

@geek geek added the proposal label Feb 27, 2018
@riot-jayb
Copy link

riot-jayb commented Dec 1, 2018

Agreed. I submitted a PR for this back in the 2.X days and was told that in 3.X there would be an option for this. Coming back nearly 2 years later, it still seems that consul is tightly coupled with containerpilot.

Ironically, I'm looking to use containerpilot to bootstrap a consul cluster in my production environment.

Can the maintainers consider a yay/nay statement on this proposal? I think there would be many within the community who would be happy to contribute this update. As proposed by @geek, this should not be a large change or burdensome for maintenance.

@riot-jayb
Copy link

@cheapRoc @tgross would you accept some external contributions here?

@tgross
Copy link
Contributor

tgross commented Dec 2, 2018

It's been quite some time since I've been a maintainer. See also #572

@ahelal
Copy link
Contributor

ahelal commented Dec 12, 2018

would be very interesting if this is implemented or open for PR

@gbmeuk
Copy link

gbmeuk commented Mar 13, 2019

does running consul as job and setting the agent in dev mode work for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants