Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test all lifecycle event types #535

Open
jwreagor opened this issue Nov 22, 2017 · 0 comments
Open

Integration test all lifecycle event types #535

jwreagor opened this issue Nov 22, 2017 · 0 comments
Labels

Comments

@jwreagor
Copy link
Contributor

I'm not seeing an integration test that exercises all possible lifecycle event types that we mention in our documentation. We should have a test or tests that showcase desired behavior of things such as...

  • enterMaintenance
  • exitFailed
  • exitMaintenance
  • shutdown
  • startup
  • stopped
  • unhealthy

Existing tests exercise the following.

  • test_discovery_consul: exitSuccess, changed
  • test_envvars: healthy
  • test_sighup: signal events SIGHUP and SIGUSR2
  • test_sigterm: stopping

I'm ok with redundancy if the tests are scattered across multiple test cases AND ALSO qualified within a single test (if that's possible).

@jwreagor jwreagor changed the title Integration test all event types Integration test all lifecycle event types Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant