Add gossip options to cooking subsection of Dalaran guards.

[heyitsbench]

Description

Guards in Dalaran when going to the cooking subsection have no gossip menu options. They should have options for both the Alliance and Horde inns.

Note: I didn't test it, just checked what was missing in TDB and pasted from WPP SQL output.

SQL fix

DELETE FROM `gossip_menu_option` WHERE `MenuID` = 10073 AND `OptionID` IN (0, 1);
INSERT INTO `gossip_menu_option` (`MenuID`, `OptionID`, `OptionIcon`, `OptionText`, `OptionBroadcastTextID`, `OptionType`, `OptionNpcFlag`, `ActionMenuID`, `ActionPoiID`, `BoxCoded`, `BoxMoney`, `BoxText`, `BoxBroadcastTextID`, `VerifiedBuild`) VALUES
(10073, 0, 0, 'Alliance Inn', 0, 1, 1, 10074, 2196, 0, 0, NULL, 0, 53788),
(10073, 1, 0, 'Horde Inn', 0, 1, 1, 10075, 2194, 0, 0, NULL, 0, 53788);

Branch

3.3.5

TC rev. hash/commit

c2f2f42

[CraftedRO]

close enough:
Table gossip_menu_option for menu 10073, id 0 use non-existing ActionPoiID 2196, ignoring
Table gossip_menu_option for menu 10073, id 1 use non-existing ActionPoiID 2194, ignoring

probably smth like this: ?

-- 
DELETE FROM `gossip_menu_option` WHERE `MenuID`=10073;
INSERT INTO `gossip_menu_option` (`MenuID`, `OptionID`, `OptionIcon`, `OptionText`, `OptionBroadcastTextID`, `OptionType`, `OptionNpcFlag`, `ActionMenuID`, `ActionPoiID`, `BoxCoded`, `BoxMoney`, `BoxText`, `BoxBroadcastTextID`, `VerifiedBuild`) VALUES
(10073, 0, 0, 'Alliance Inn', 32133, 1, 1, 10074, 137, 0, 0, '', 0, 0),
(10073, 1, 0, 'Horde Inn', 32134, 1, 1, 10075, 138, 0, 0, '', 0, 0);

[heyitsbench]

probably smth like this: ?

Is adding the POIs referenced not an option? Here they are as well (since I didn't realize they were missing):

DELETE FROM `points_of_interest` WHERE `ID` IN (2194, 2196);
INSERT INTO `points_of_interest` (`ID`, `PositionX`, `PositionY`, `Icon`, `Flags`, `Importance`, `Name`, `VerifiedBuild`) VALUES
(2194, 5885.6201171875, 521.7760009765625, 7, 99, 0, 'Dalaran Horde Inn', 53788),
(2196, 5731.4599609375, 678.198974609375, 7, 99, 0, 'Dalaran Alliance Inn', 53788);

[CraftedRO]

Idk same value already exist with other id, I guess both options are valable:

SELECT * FROM `points_of_interest` WHERE `ID` IN (137,138);
(`ID`, `PositionX`, `PositionY`, `Icon`, `Flags`, `Importance`, `Name`, `VerifiedBuild`) VALUES
(137, 5731, 678.199, 7, 99, 0, 'Dalaran Alliance Inn', 0),
(138, 5885, 521.776, 7, 99, 0, 'Dalaran Horde Inn', 0);

[CraftedRO]

if you want you can sniff the innkeeper gossip too and if it have different id then we have to insert new values too

[heyitsbench]

if you want you can sniff the innkeeper gossip too

The guard gossip for where the inns are came with the same POIs as where the cooking trainers are, IDs 2194/2196.

[CraftedRO]

then I guess we have to use (137,138) to save few kb of database size and it seems blizzard devs are not so dumbs as I thought afterall 😏

[meji46]

I think that during 3.3.5, POI ids weren't sent to the client so it was used the first one that was free. 2194 & 2196 are the right ones

Here is the fix made for master with all the ids (I understand you should ignore the archaeology one): d28a5b7

[heyitsbench]

May be worth while to sniff all the direction gossips we can while Wrath is still kicking then. 😛

[Aokromes]

i wonder if we must sniff every gossip with wow 3.4.3