Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python version to 3.9 #7869

Open
5 of 7 tasks
drew2a opened this issue Jan 30, 2024 · 7 comments
Open
5 of 7 tasks

Update python version to 3.9 #7869

drew2a opened this issue Jan 30, 2024 · 7 comments
Assignees
Milestone

Comments

@drew2a
Copy link
Collaborator

drew2a commented Jan 30, 2024

To complete the task, we should:

  • Update all builders (@xoriole).
    • macOS
    • Linux
    • Win64
    • Win32
  • Update GitHub actions (@drew2a).
  • Update documentation (@drew2a).

Ref:

@xoriole
Copy link
Contributor

xoriole commented Jan 30, 2024

I have opted to use pyenv for setting up the python environment and updated the Jenkins script to use the correct python using pyenv local setup. So far, macOS and Linux builders are updated and the build seems to work too. But, Windows installation seems a bit challenging.

@drew2a
Copy link
Collaborator Author

drew2a commented Jan 31, 2024

For Windows, you might consider using Chocolatey as it may simplify things: Python 3.9 on Chocolatey.

@xoriole
Copy link
Contributor

xoriole commented Feb 1, 2024

The reason why Python3.9 was not working on our builders is because Python3.9 is not supported on Win7. Therefore, the windows builders need to be upgraded. This will likely affect some users using Win7 still.

I'll upgrade the builders on Win10 machines.

Ref: https://bugs.python.org/issue41412

@xoriole
Copy link
Contributor

xoriole commented Feb 1, 2024

Priority for upgrading the builders is put on hold until the existing bugs are fixed.
I'm unassigning myself till it becomes a priority again.

@xoriole xoriole removed their assignment Feb 1, 2024
@drew2a
Copy link
Collaborator Author

drew2a commented Feb 1, 2024

@xoriole, "until the existing bugs are fixed" does sound a bit like "never"...

It seems like I should revert the changes I made to GitHub Actions because now it's possible that one of the developers will use a feature from Python 3.9, which will pass all the tests in a PR as they operate with Python 3.9. However, when we try to build the next release (for example, 7.14), we might encounter these incompatibilities since the builders use Python 3.8.

@drew2a
Copy link
Collaborator Author

drew2a commented Mar 27, 2024

@drew2a drew2a removed their assignment Apr 11, 2024
@xoriole xoriole self-assigned this May 22, 2024
@xoriole
Copy link
Contributor

xoriole commented May 24, 2024

Update on this ticket:
Windows 64bit builder machine is upgraded to support Python3.9. This was used to build the TriblerExperimental release (win64) yesterday.

A few notes:

  • The builder is on Win10. The build created on Win10 does not work on Win7 (tested and confirmed).
  • The same build script that worked on Win7 did not work on Win10, requiring changes. Those changes on the build script are currently on TriblerExperimental and need to be imported back to Tribler main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants