Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Breadcrumbs #26

Open
4 tasks
rohrig opened this issue Jun 22, 2023 · 3 comments
Open
4 tasks

Add Breadcrumbs #26

rohrig opened this issue Jun 22, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@rohrig
Copy link
Collaborator

rohrig commented Jun 22, 2023

@rohrig rohrig added enhancement New feature or request good first issue Good for newcomers labels Jun 22, 2023
@faizanarif121 faizanarif121 self-assigned this Jun 25, 2023
@faizanarif121
Copy link
Collaborator

@rohrig for this task I've following questions

  • Do we need to extend sdk and add new query for bread crumbs?
  • Why do we need to add it in default layout, other pages like cart, checkout etc. I think we can add it in apps/nuxt/pages/[...slug].vue. What do you say?

@rohrig rohrig removed the good first issue Good for newcomers label Jun 25, 2023
@rohrig
Copy link
Collaborator Author

rohrig commented Jun 25, 2023

@faizanarif121 Those are very valid points.

It looks like this is perhaps not a good first issue after all. 😁

I had a look at V2 and the solution there is not exactly trivial. You can check there for inspiration, but we are by no means bound to anything there. If you find a cleaner, better way to do it, that's great.

It looks like there is a separate solution for the category page and the product pages. I'll adjust the issue description accordingly.

If you're up for it. You could plan a solution. I'm happy to support you in any way I can. We can continue the discussion here or if you like you could create an RFC in the discussions tab above with your proposed solution so others can give feedback before you code the solution. This is not required, but it might be a good idea. If you want to just dig in and code the solution, I'm happy with that, too.

@faizanarif121
Copy link
Collaborator

faizanarif121 commented Jun 27, 2023

sure @rohrig. I've holidays starting from tomorrow, I'll look into it once I'm back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants