Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with Yarn 2's workspace protocol? #104

Open
WaldoJeffers opened this issue Aug 17, 2021 · 2 comments
Open

Incompatibility with Yarn 2's workspace protocol? #104

WaldoJeffers opened this issue Aug 17, 2021 · 2 comments

Comments

@WaldoJeffers
Copy link

WaldoJeffers commented Aug 17, 2021

Hello,

Thanks for this great CLI tool!

What I see
I've just started using it, and it seems manypkg reports an error when the root of a monorepo uses Yarn 2's workspace protocol :workspace

This an example error report:

☔️ error root has a dependency on @private/library@workspace:libraries/library
but the version of @private/library in the repo is 3.16.13
which is not within range of the depended on version,
please update the dependency version

Expected
In this case, I would expect manypkg not to report an error, since the root will naturally use the latest available version.

What do you think?

@WaldoJeffers
Copy link
Author

Hello,

Any thoughts on this?
cc @mitchellhamilton @Andarist

It's currently preventing us from using manypkg because of this. I could definitely do a PR if you agree on the expected behaviour. Or close this issue if it's never going to happen?

@Andarist
Copy link
Collaborator

I think supporting the workspace protocol is a good idea. Could you prepare a failing test first so we could check the very exact situation in which this failure can happen? The fix for the issue could be then added on top of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants