Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow customizing commit messages #1051

Closed
wants to merge 4 commits into from
Closed

feat: allow customizing commit messages #1051

wants to merge 4 commits into from

Conversation

stefanprobst
Copy link
Contributor

closes #1033

this allows providing custom commit messages via the storage config in keystatic.config.ts:

{
  kind: "github",
  repo: { owner: "stefanprobst", name: "keystatic-test" },
  commitMessages: {
    update({ path }) {
      return `content: update ${path}`
    },
    delete({ path }) {
      return `content: delete ${path}`
    },
  }
}

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2024 •
edited

🦋 Changeset detected

Latest commit: d864ef9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@keystatic/core Patch
@keystar/docs Patch
@example/astro-content Patch
@example/astro Patch
@example/localization Patch
@example/next-app Patch
@example/next-block-builder Patch
@example/next-pages Patch
@keystatic/remix-test-app Patch
keystatic-docs Patch
@keystatic/templates-astro Patch
@keystatic/templates-nextjs Patch
@keystatic/templates-remix Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 3, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
keystatic-site ✅ Ready (Inspect) Visit Preview Apr 9, 2024 10:31pm
3 Ignored Deployments
Name Status Preview Updated (UTC)
keystar-ui ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2024 10:31pm
keystatic ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2024 10:31pm
keystatic-next-blocks-builder ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2024 10:31pm

@emmatown
Copy link
Member

emmatown commented Apr 9, 2024

Thanks for the PR! Unfortunately we can't accept it because we're planning to change how committing works so many changes can be batched into a single commit so these messages wouldn't make sense. Those changes will allow users to customise the commit message in the UI though and we could look into customising the defaults once that is in.

@emmatown emmatown closed this Apr 9, 2024
@stefanprobst stefanprobst deleted the feat/custom-commit-messages branch April 10, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmatown emmatown Awaiting requested review from emmatown emmatown is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow customizing commit messages
3 participants
@stefanprobst @emmatown @jossmac