Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this project still alive? #995

Open
iahim opened this issue Aug 28, 2022 · 12 comments
Open

Is this project still alive? #995

iahim opened this issue Aug 28, 2022 · 12 comments

Comments

@iahim
Copy link

iahim commented Aug 28, 2022

I don't see too much movement in the last 2 years...

@peterlaws
Copy link

I still use it religiously.

@mihaiflorio
Copy link

I still use it religiously.

I have tried to use it lately but i have a warning ... using php 7.4.30.
PHP Notice: Undefined offset: 0 in vendor/thingengineer/mysqli-database-class/MysqliDb.php on line 559

@peterlaws
Copy link

That is just a notice - but it works despite that??...... I use it with 8.0, no issues...

But, I agree, would like some input from the author, @ThingEngineer

@mihaiflorio
Copy link

That is just a notice - but it works despite that??...... I use it with 8.0, no issues...

But, I agree, would like some input from the author, @ThingEngineer

Yeah it does work, is just annoying :)

@avbdr
Copy link
Collaborator

avbdr commented Sep 11, 2022 via email

@mihaiflorio
Copy link

@avbdr on php 7.4.30 seems to work just fine (apart of the notice). Thanks a lot for fixing it.

@funder7
Copy link

funder7 commented Sep 10, 2023

Hi guys, I'm using this package since 2016 and it worked always very well.
In the next months I'll need to migrate a project to php 8.x, and I would like to keep using this library if possible. It's not 100% clear if it's compatible with php 8, as there are some open issues about it, while some people says that it's working.
I can give some support if needed...

Just let me know, in case. Bye!

@iahim
Copy link
Author

iahim commented Sep 11, 2023

@funder7 it does work, i use it with php8. there is indeed that weird notice (but it does not break the code).
I was thinking about forking it ... if the owner does not update it anymore.

@avbdr
Copy link
Collaborator

avbdr commented Sep 11, 2023

I dont know what else to add to the library, I think it is good as is and further "improvements" less likely will bring anything major anymore.
I have to sit to fix php8 related deprecation notices with a backwards compatibility, this is so far the only thing in my todo

@iahim
Copy link
Author

iahim commented Sep 11, 2023

@avbdr totally agree, there is no need for further improvements, just the fix for php8. I do not think is too much work, I can pay you to fix it (my OCD always is getting crazy when I see the NOTICE from the library) :))))))
I am serious about it - let me know how much it costs, to have it fixed sooner than later.

@peterlaws
Copy link

(my OCD always is getting crazy when I see the NOTICE from the library) :))))))

You should only have notices on for debugging....... So you'd pay for something to be fixed when you have the option to turn off........ Hell, I'd fix it for £100.........

@funder7
Copy link

funder7 commented Sep 16, 2023

I dont know what else to add to the library, I think it is good as is and further "improvements" less likely will bring anything major anymore.
I have to sit to fix php8 related deprecation notices with a backwards compatibility, this is so far the only thing in my todo

Sure, I was referring to fixing any warning to make it fully compatible with php 8.x, no need to add other functionalities IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants