Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong implode function parameters #1019

Open
nathanaelmemis opened this issue Aug 21, 2023 · 1 comment
Open

wrong implode function parameters #1019

nathanaelmemis opened this issue Aug 21, 2023 · 1 comment

Comments

@nathanaelmemis
Copy link

nathanaelmemis commented Aug 21, 2023

MysqliDb.php, line 1838:
$this->_query .= ' (' . implode($dataColumns, ', ') . ') ';

should be

$this->_query .= ' (' . implode(', ', $dataColumns) . ') ';

note: this is for the last release

@decMuc
Copy link

decMuc commented Dec 2, 2023

I find this surprising. I have an insert statement in two different classes – it works in one class, but in the other, I encounter an error in the exact same line. When I swap the line between the classes, it now works in the previously problematic class. I just can't comprehend why it works in one class while being nearly identical to the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants