Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to add HTTP Headers to the authenticate call #57

Open
kylethompson-hs opened this issue Aug 10, 2023 · 7 comments
Open

Provide a way to add HTTP Headers to the authenticate call #57

kylethompson-hs opened this issue Aug 10, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@kylethompson-hs
Copy link

I'm using this package to authenticate with my backend server. I'd like to be able to pass some header values along with the URL open call to my server. As far as I can tell this isn't supported today.

@kylethompson-hs kylethompson-hs added the enhancement New feature or request label Aug 10, 2023
@ThexXTURBOXx
Copy link
Owner

That sounds like a great feature request which I will take a look at after my vacation (in around two to three weeks)! 😊

@ThexXTURBOXx
Copy link
Owner

I have a huge refactor planned which should be able to tackle this task. However, it will need quite some time

@ThexXTURBOXx
Copy link
Owner

The huge refactor is online in version 3.0.0-alpha.1. However, there seems to be very limited support for headers from url_launcher's side of things. Due to this, I will postpone this a bit more until I find a better solution to make url_launcher accomplish that

@kwent
Copy link

kwent commented Mar 13, 2024

Looks like url_launcher supports headers now https://pub.dev/documentation/url_launcher/latest/url_launcher/launch.html

@ThexXTURBOXx
Copy link
Owner

https://pub.dev/documentation/url_launcher/latest/url_launcher/WebViewConfiguration/headers.html

"Not all browsers support this, so it is not guaranteed to be honored."

Additionally, it is restricted to Android only. But I have already implemented this a few weeks ago in my local build of the 4.0.0 alpha - so the next preview will at least support this on Android.

@ThexXTURBOXx
Copy link
Owner

I just wanted to push my changes, but I noticed that they are not even applied on Android since we are not using url_launcher on Android - in favor of a native solution. Hence, this is still not possible (and the headers parameter @kwent mentioned was already available when this issue was created and I was even aware of it)

@kwent
Copy link

kwent commented Mar 13, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants