Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: China TNT Bombs now hit structures with their primary damage reliably #2375

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xezon
Copy link
Collaborator

@xezon xezon commented Oct 8, 2023

With this change the primary damage of the China TNT Bomb can now hit structures reliably. Before they would hit with their secondary damage most of the time, because the TNT Bombs would be located too far away from the target structure.

Placing the TNT Bomb on an approaching vehicle still works before the instigator is crushed. Damage on vehicles is unchanged, because the TNT Bomb is placed at the center of the vehicle, meaning it will apply primary damage always.

The reduced ability range requires Tank Hunters to walk closer to their target before the TNT bomb is placed. The increased primary damage radius gives the TNT bomb more reach.

Damages

The damage surplus of a correctly placed TNT Bomb is significant. Buildings will now suffer +233% explosion damage from a single TNT Bomb.

Weapon TNTDetonationWeapon ;Created by tankhunters
  PrimaryDamage = 500.0
  PrimaryDamageRadius = 15.0
  SecondaryDamage = 150.0
  SecondaryDamageRadius = 50.0
...
End

Original

generals.2023-10-08.12-10-31-87.mp4

Patched

generals.2023-10-08.10-45-06-10.mp4

@xezon xezon added Bug Something is not working right Controversial Is controversial Major Severity: Minor < Major < Critical < Blocker Buff Makes a thing more powerful China Affects China faction labels Oct 8, 2023
@xezon
Copy link
Collaborator Author

xezon commented Oct 8, 2023

This is a massive buff for all China.

@xezon xezon added the Design Is a matter of game design label Oct 8, 2023
@penfriendz
Copy link

This is one of those buff not really buff kinda things. For people who knew how to take advantage of this, this is a massive convenience and increase in consistency. For people that don't, they can now do what only people with insider knowledge could do, and for these people the impact is greatest.

In any case, let's get a table of bombs to kill for each building and pick a damage value which is sensible.

@xezon xezon changed the title Fix: Decreases ability range of China TNT Bomb from 5.0 to 0.0 Fix: China TNT Bombs now hit structures with their primary damage reliably Oct 8, 2023
@xezon
Copy link
Collaborator Author

xezon commented Oct 8, 2023

I have now also increased the PrimaryDamageRadius from 10 to 15, which helps to apply primary damage in some edge cases.

@MTKing4
Copy link
Collaborator

MTKing4 commented Oct 11, 2023

Placing the TNT Bomb on an approaching vehicle still works before the instigator is crushed. Damage on vehicles is unchanged, because the TNT Bomb is placed at the center of the vehicle, meaning it will apply primary damage always

I Assume this is not tested thoroughly, it needs to

Besides the big damage buff to buildings, i predict it to buff vs clumped units as well, since now the range is higher, you might kill 2 or 3 units with one TNT

@xezon
Copy link
Collaborator Author

xezon commented May 28, 2024

I Assume this is not tested thoroughly, it needs to

I think I tested it against AI, which always goes for crush against infantry and it worked. But we can retest.

Besides the big damage buff to buildings, i predict it to buff vs clumped units as well, since now the range is higher, you might kill 2 or 3 units with one TNT

I think I tested this too and natural distance between vehicles is wider. But we can restest. It would be useful to find out what the regular min distance between vehicles is (there is one to avoid collision).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Buff Makes a thing more powerful Bug Something is not working right China Affects China faction Controversial Is controversial Design Is a matter of game design Major Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TNTStickyBomb is placed too far away from buildings and applies secondary damage most of the time
3 participants