Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Tab order" skips elements in shadow DOM #52

Open
oczki opened this issue Jan 9, 2024 · 1 comment
Open

"Tab order" skips elements in shadow DOM #52

oczki opened this issue Jan 9, 2024 · 1 comment

Comments

@oczki
Copy link

oczki commented Jan 9, 2024

Describe the bug

The "Tab order" highlight feature doesn't point the arrows to tabbable elements in shadow root (open).
As a result, the extension's user might think that their <button> or <a> is not reachable via keyboard, while in fact they work normally. It's just that the extension skips them.

To Reproduce

  1. Go to https://www.ig.com/uk
  2. Open ARC Toolkit in dev tools, then Highlight, then Tab order
  3. See that the arrows don't point to elements that can be reached by the user via keyboard

Expected behavior

Arrows should show the correct tab order across all elements, including shadow DOM.

Screenshots

On https://www.ig.com/uk - links in some sections are kept in shadow root (open). As the screenshot shows, I've tabbed to one of the links (it has a black outline). On the right side of the screenshot, the elements tree shows one of the <a> elements in an open shadow root. The tab order arrows are incorrect on this site.

image

Version information

  • Browser and version: Brave 1.61.114 (Chromium: 120.0.6099.199) 64-bit
  • ARC Toolkit version: 5.6.0
@ferllings ferllings added bug Something isn't working and removed bug Something isn't working labels Jan 12, 2024
@ferllings
Copy link
Member

Shadow DOM is not supported yet.
Let's keep that ticket open to test once available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants