Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node-level contrast checker #5

Open
dabrams888 opened this issue Jul 13, 2022 · 4 comments
Open

Node-level contrast checker #5

dabrams888 opened this issue Jul 13, 2022 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@dabrams888
Copy link

Is your feature request related to a problem? Please describe.

The previous version of ARC Toolkit added a tab next to the Styles pane of the developer tools which allowed you to run automated color contrast analysis on the currently selected DOM node. This feature does not appear to be in the updated version of Toolkit. The feature was quite useful as it allowed you to quickly double check the contrast of various nodes in the DOM without having to start up separate software like CCA. It also runs automatically based on the node's color properties which means the user does not have to manually locate and copy/paste hex values in order to check contrast.

Describe the solution you'd like

Add this feature into the rebuilt version of Toolkit.

Describe alternatives you've considered

Alternate solutions would require manually locating the correct hex values in dev tools and inputting them into CCA. This is viable, but does take considerably longer if trying to check multiple nodes.

Additional context

Not looking for anything above and beyond what the previous version had. Just looking for parody.

@mikeharsh
Copy link

@dabrams888 Came here to report the same issue, so thanks. I've found that the "Run on selected node only" checkbox appears above the "Run tests" button if you refresh the browser window/tab after the extension is first opened in dev tools. It's not ideal, but at least there is a workaround until they fix the bug.

@poorgeek poorgeek added the enhancement New feature or request label Jul 15, 2022
@poorgeek poorgeek added this to the 5.5.0 milestone Jul 20, 2022
@mikeharsh
Copy link

The workaround I mentioned on Jul 14 no longer appears to be working. The "Run on selected node only" checkbox does not limit the tests to the selected node. This bug is not limited to the node-level contrast checker (as noted in the issue title). It affects the ability to limit any/all tests to a specific area, which has become the primary reason I use this extension instead of axe DevTools (which charges for this feature).

Version 5.4.2 on Google Chrome (Mac desktop version 106.0.5249.91).

In the attached video, there are 2 issues:

  1. The "Run on selected node only" checkbox is not present when ARC ToolKit is initially opened in dev tools. I have to refresh the entire page for that checkbox to appear.
  2. I choose an element as the selected node. The results returned are for the entire page, not limited to the img element.
    arc-toolkit-bug.webm

@ferllings
Copy link
Member

Please note that the Node-level contrast checker has been re-introduced. Could you check if this is working?

  1. That's a bug. For now you need to open Toolkit first, then select the node
  2. The is already in the pipe for the next version

@dabrams888
Copy link
Author

dabrams888 commented May 18, 2023

Not sure if there is a bug with the node-level selection in general. But I frequently go to use it and the checkbox just isn't there. I'm on version 5.5.3. Can't really verify this until that is working.

I'm not sure if it makes any difference but most of the pages I'm using it with lately are single page applications. Maybe there is something with the DOM changes that's causing toolkit to not see the selected nodes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants