Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<iframe> elements break Toolkit's Highlight feature #40

Open
aaronbnb opened this issue Aug 9, 2023 · 1 comment
Open

<iframe> elements break Toolkit's Highlight feature #40

aaronbnb opened this issue Aug 9, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@aaronbnb
Copy link

aaronbnb commented Aug 9, 2023

Describe the bug
<iframe> breaks ARC Toolkit's Highlight feature.

When a page contains an <iframe> which contains an element that ARC Toolkit can highlight, ARC Toolkit highlights the elements in the viewport but does not display the element in the DevTools pane. This issue applies to all highlightable elements - such as:

  • Headings
  • Lists
  • Table
  • ARIA usage
  • ARIA hidden
  • ARIA UI
  • tabindex
  • IDs
  • Landmarks

For example, when a page contains an <iframe> which contains a heading nested within that <iframe>, ARC Toolkit's Highlight Headings feature highlights the headings on the page in the viewport but does not display any heading elements within the DevTools pane.

To Reproduce
For this example, let's use headings or form fields:

  1. Go to a page which has an <iframe> which contains a heading (either native or ARIA role="heading") or a form field
  2. Open ARC Toolkit and select Highlight
  3. In Highlight, select Highlight Headings or Forms
  4. Note that the headings and form fields on the page (and within the <iframe>) are highlighted in the viewport but not displayed within the DevTools pane

Test Case: Acme Restaurant - test site
The <iframe> contains an <h2> and multiple <input>.

Screenshots
Screenshot shows that the webpage contains an iframe elements which has form fields and ARC Toolkit highlights the main page and iframe's form fields in the viewport but the devtools pane is blank
Note that the DevTools pane is blank.

Expected behavior

  1. The elements highlighted in the browser viewport should also be displayed in the DevTools pane
  2. In the DevTools pane, the elements should be displayed AND indicated as being located within an <iframe>

Version information

  • Browser and version: Chrome 101*
  • ARC Toolkit version: 5.5.3

Notes
This issue was reported by an external education institution which uses ARC Toolkit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants