Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Spacing feature does not apply spacing following paragraphs #31

Open
dabrams888 opened this issue Feb 7, 2023 · 0 comments
Open

Comments

@dabrams888
Copy link

Describe the bug

SC 1.4.12 including the following style property:

Spacing following paragraphs to at least 2 times the font size;

For web-based content, it's recommended that this be tested using the following CSS:

p {
    margin-bottom: 2em !important;
}

Currently, the ARC Toolkit feature for adjusting text spacing seems to apply the other 3 properties from this SC, but not spacing following paragraphs.

To Reproduce

  1. In ARC Toolkit, go to 'Highlight'
  2. Select the option to 'Check Text Spacing'
  3. Inspect the page styles and/or visually check the style differences on the page.
  4. The following CSS is injected, which does not include paragraph spacing.
body.arcTextSpacingHelper * {
  line-height: 1.5 !important;
  letter-spacing: 0.12em !important;
  word-spacing: 0.16em !important;
}

Expected behavior

The Text Spacing feature in ARC Toolkit applies all of the style properties that are specifically called out in SC 1.4.12 to the best of its ability.

Note that I say 'to the best of its ability' here because there is an assumption that authors are using HTML <p> elements to define paragraphs of text. This is not always the case and it is not uncommon for authors to use generic <div> elements or similar for blocks of text. However, applying these properties to generic elements like <div> would be unwise, and not a good representation of the intent of this criteria.

Version information

  • Browser and version: Google Chrome version 109.0.5414.119
  • ARC Toolkit version: 5.4.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant