Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript: Update place ship instruction #27890

Open
3 tasks done
Baguirre03 opened this issue Apr 29, 2024 · 5 comments
Open
3 tasks done

JavaScript: Update place ship instruction #27890

Baguirre03 opened this issue Apr 29, 2024 · 5 comments
Assignees

Comments

@Baguirre03
Copy link
Contributor

Checks

Describe your suggestion

Here is the current direction within the project:

Gameboards should be able to place ships at specific coordinates by calling the ship factory or class.

I think this could be reworded, as some people may think that this means the ship object must have a place() method. But instead the only thing you really need to do is have the ship object somewhere within the gameboard array.

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/node-path-javascript-battleship

(Optional) Discord Name

mfraryay

(Optional) Additional Comments

We <3 open source! First issue in a while here :shoc

@MaoShizhong
Copy link
Contributor

Thanks for opening this issue @Baguirre03.
Do you happen to have any links/examples of where this caused a problem for people?
It's not one I've particularly noticed being a pain point, and my initial read would be that calling the factory or class would construct a new Ship object, where then the gameboard placement would (?) seem intuitive.

But of course, if this has been an actual pain point then we can definitely look to address the wording.

@Baguirre03
Copy link
Contributor Author

It happened only a couple of times where i have seen it be a little confusing for people in the discord! Im okay with keeping it how it is though :salute:

Maybe a simple rewording?

Gameboards should have a placeShip function which calls the Ship factory or class and places it at specific coordinates

@MaoShizhong
Copy link
Contributor

MaoShizhong commented May 9, 2024

What do you think about the following?

Gameboards should have a placeShip function that creates a new Ship object then places it at the specified coordinates.

@Baguirre03
Copy link
Contributor Author

bueno 👍

@MaoShizhong
Copy link
Contributor

Assigned @Baguirre03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants