You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are a few places in reporter.py where we reach into the internals of coverage to do what we need to do. It would be great if we could avoid doing this; wherever we can refactor to use the public interface, great. If the public interface needs to change, we can work with upstream to tackle that.
Once this is done, we'll be able to finally avoid getting broken by occasional non-major coverage updates.
The text was updated successfully, but these errors were encountered:
coverage.reporter.FilePlugin has .relative_filename() -> str
coverage.reporter.FilePlugin has .source_token_lines() -> Iterable[Any]
coverage.reporter.FilePlugin has .source() -> str
coverage.results.Analysis has .missing -> set[int]
coverage.results.Analysis has .statements -> set[int]
coverage.results.Analysis has .has_arcs -> bool
coverage.results.Analysis has .missing_branch_arcs() -> dict[int, list[int]]
coverage.results.Analysis has .executed_branch_arcs() -> dict[int, list[int]]
As of coverage v6.3+, all of the above are non-private methods. Calling this one done!
/cc @nedbat FYI on this, as we've crossed paths on my use of private interfaces before. coveralls should now be strictly following your public interface, so we shouldn't get any unexpected conflicts on minor versions. Please do let me know if any of the above are not meant to be public interfaces, and I'd be happy to look into changing my code!
There are a few places in
reporter.py
where we reach into the internals ofcoverage
to do what we need to do. It would be great if we could avoid doing this; wherever we can refactor to use the public interface, great. If the public interface needs to change, we can work with upstream to tackle that.Once this is done, we'll be able to finally avoid getting broken by occasional non-major
coverage
updates.The text was updated successfully, but these errors were encountered: