Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing the generic cast from UnmodifiableConfig.get (WDYT?) #172

Open
TheElectronWill opened this issue May 12, 2024 · 0 comments
Open

Consider removing the generic cast from UnmodifiableConfig.get (WDYT?) #172

TheElectronWill opened this issue May 12, 2024 · 0 comments
Labels
enhancement ⬆️ waiting-for-reply

Comments

@TheElectronWill
Copy link
Owner

It seems that the automatic casts confuse/surprise some people (cf. NeoForge server).
What do you guys think? Should we keep config.get<T> or require an explicit type, such as config.getXYZ or config.get(Class<T>)?
@TheElectronWill TheElectronWill changed the title Consider removing the generic cast from UnmodifiableConfig.get Consider removing the generic cast from UnmodifiableConfig.get (WDYT?) May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ⬆️ waiting-for-reply
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TheElectronWill