Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large number of entries in a multiacquisition table slows down initial imaging #450

Closed
zacsimile opened this issue May 18, 2023 · 4 comments · Fixed by #896
Closed

Large number of entries in a multiacquisition table slows down initial imaging #450

zacsimile opened this issue May 18, 2023 · 4 comments · Fixed by #896
Assignees
@annie-xd-wang
Labels
low priority low priority task refactoring Improving existing code by either reduction, readability, ease of use or some combination

Comments

@zacsimile
Copy link
Collaborator

After running VolumeSearch, if I have a large number of entries in the multi-acquisition table, it takes a long time to start an acquisition. I press Acquire and it takes about 30 seconds to start. If I delete the positions, it is quick again.
@AdvancedImagingUTSW
Copy link
Collaborator

We naively jammed the pandas table into there since it worked with tk, and Annie kindly made it functional. But it may honestly be one of our weakest dependencies. We could easily consider something else.

@zacsimile zacsimile mentioned this issue May 23, 2023
Merged
@zacsimile zacsimile added refactoring Improving existing code by either reduction, readability, ease of use or some combination low priority low priority task labels Nov 4, 2023
@zacsimile
Copy link
Collaborator Author

Further investigation reveals the slowdown comes not from pandas, but from aslm.config.config.build_nested_dict(). Likely from multiple assignments to the multiprocessing.Manager() object, possibly slower due to recursion.

@zacsimile zacsimile mentioned this issue Jan 7, 2024
Closed
@AdvancedImagingUTSW
Copy link
Collaborator

Now that I am using the Volume Search feature, this is rearing its ugly head again...

@AdvancedImagingUTSW
Copy link
Collaborator

I have also seen something where the multi position table must have at least one entry in it, or else an error is thrown.

@annie-xd-wang annie-xd-wang linked a pull request May 22, 2024 that will close this issue
Update multiposition table #896
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annie-xd-wang annie-xd-wang

Labels
low priority low priority task refactoring Improving existing code by either reduction, readability, ease of use or some combination
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update multiposition table annie-xd-wang/navigate
3 participants
@zacsimile @annie-xd-wang @AdvancedImagingUTSW