New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in ihp-sg13g2 jpeg flow #1953
Comments
It appears this design is not running in the CI. |
Should we remove the |
Probably we should just get the base case working or remove the whole design. Can the autotuner find a working configuration? |
@povik this appears to be an yosys-abc crash. Should that be reported to yosyshq or directly to abc? |
If I run yosys-abc myself I see
|
Hah, just the other way I was looking at the buffering code and noting those assertions don't make such sense (the units there are such that 1 shouldn't be a special value), so I suspect the fix is to simply remove those. |
Generally I think one has better chances with opening a Yosys issue than reporting it to the upstream abc project. Here though the issue can be pointed out easily so maybe an abc report would work too. We carry some downstream patches for abc issues and the prospect of getting those mainline are uncertain. |
@povik if you are planning to look at it I could just assign this issue to you or I could transfer it to yosyshq. |
It's not something I was planning to look at, but feel free to assign it to me, I just don't know when I will get to it. When I do, I can confirm removing the assertions does the trick (and double-check the assertions are nonsensical). |
@QuantamHD FYI in case Alan wants to look at this directly. |
Alan won't fix any bugs for you, but if you open PRs we can email him to get him to review. |
@povik could you make a PR removing the assertions you believe are wrong? |
I confirm the reported bug.
be replaced by:
That could be a clue. |
From the above findings ('-c' in abc_speed.script) i guess : abc. |
Subject
Describe the bug
Flow terminates at yosys synthesis stage.
Expected Behavior
Should not terminate.
Environment
To Reproduce
cd flow && make DESIGN_CONFIG=./designs/ihp-sg13g2/jpeg/config.mk
Relevant log output
Screenshots
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: