Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: check if numbers of warnings increasemin CI #1905

Open
oharboe opened this issue Apr 2, 2024 · 0 comments
Open

Feature request: check if numbers of warnings increasemin CI #1905

oharboe opened this issue Apr 2, 2024 · 0 comments
Assignees
@vvbandeira

Comments

@oharboe
Copy link
Collaborator

oharboe commented Apr 2, 2024 

          > @maliberty I seem to recall you added number of warnings and errors to the `make metadata` information?

Does this mean that if there is a regression(increase) in number of warnings that this will now be caught by CI and that a choice can be made whether or not to accept the new warnings?

It means only that it is recorded currently. We could need to set limits to check against. It seems unrelated to this PR though

Originally posted by @maliberty in The-OpenROAD-Project/OpenROAD#4889 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vvbandeira vvbandeira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oharboe @vvbandeira