Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Finish implementing Shaia and Lewin NPCs #1163

Open
GrenderG opened this issue Jun 8, 2023 · 2 comments
Open

TODO: Finish implementing Shaia and Lewin NPCs #1163

GrenderG opened this issue Jun 8, 2023 · 2 comments
Labels
database Issues related to the database npc Issues related with NPCs todo This is a task to be done

Comments

@GrenderG
Copy link
Member

GrenderG commented Jun 8, 2023

Describe what needs to be implemented or enhanced
They are vendors but they aren't selling anything nor have the proper flag.

Expected end result
They should actually be vendors selling the proper armors. Currently both Melea and Shaia have the same subname, we should also investigate if this is correct and what should each of them sell.

4178 Shaia
4239 Lewin

@GrenderG GrenderG added todo This is a task to be done database Issues related to the database npc Issues related with NPCs labels Jun 8, 2023
@mindphluxnet
Copy link
Contributor

Interestingly, Shaia was not spawned in Vanilla (at least according to Wowhead Classic). It's likely she existed in alpha and sold exactly the same stuff as Melea until the devs decided she wasn't needed. So if anything she should have the exact same inventory as Melea.

Lewin also no longer existed in Vanilla/Classic. He should likely sell whatever other leather armor merchants were selling back then.

If you give the OK I can implement this.

@geo-tp
Copy link
Collaborator

geo-tp commented Jan 25, 2024

image

I think you are right, these sellers seem to have been deleted because they all sold the same thing, some of them have also been modified to sell other types of armor later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database Issues related to the database npc Issues related with NPCs todo This is a task to be done
Projects
None yet
Development

No branches or pull requests

3 participants