Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Allow running a tainted runner #264

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JRaspass
Copy link
Contributor

STILL WIP. DO NOT MERGE

This allows tainted tests to benefit from the preload feature, fixes #262.

@exodist
Copy link
Member

exodist commented Feb 25, 2023

I am not bothered by the untaint, this proof of concept looks good. It will need a t/integration test that verifies it, as well as the cleanup and polish you already mentioned needing.

The one thing I would change about untaint() is that I would make it so that at load time it checks if taint mode is enabled, if it is then define sub untaint as you have, but if taint mode is not enabled just return the argument and skip the regex, as a minor performance enhancement when taint is not used.

The test is essential becaus eI will almost certainly break this feature without a test to save me from that. The test should skip on platforms/perls where taint mode is not available.

Adds a `--taint` flag to run the runner under taint mode. Only tests
with a taint argument in their shebang will be subject to preloading.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preload is useless with tainting
2 participants