Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node v18 #7057

Closed
wants to merge 11 commits into from
Closed

Node v18 #7057

wants to merge 11 commits into from

Conversation

ljowen
Copy link
Contributor

@ljowen ljowen commented Feb 22, 2024

What this PR does

Fixes #7056

Update node to v18, webpack to v5

Test me

Run webpack builds and confirm everything builds correctly

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@steve9164
Copy link
Member

Build error is due to @types/react duplication. Running yarn-deduplicate (https://github.com/scinos/yarn-deduplicate) will probably fix the yarn.lock duplication issue.

@ljowen
Copy link
Contributor Author

ljowen commented Feb 29, 2024

Build error is due to @types/react duplication. Running yarn-deduplicate (https://github.com/scinos/yarn-deduplicate) will probably fix the yarn.lock duplication issue.

Thanks Crispy! yarn-deduplicate failed to remove the duplicates so instead of opted to add resolutions: {..., "@types/react": "^17.0.3"} We should be able to then remove this with React18

facebook/react#24304

@ljowen ljowen closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Webpack to v5, switch to Node v18
2 participants
@ljowen @steve9164