New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WMTS tile height/width isn't pulled from Tile Matrix Set #7054

Open

nf-s opened this issue Feb 21, 2024 · 0 comments

Contributor

nf-s commented Feb 21, 2024 •

edited

To reproduce

Add the following WMTS server - https://base.maps.vic.gov.au/service?service=WMTS&request=GetCapabilities&version=1.0.0
Add "Vicmap Basemap - Web Mercator - Aerial" layer
Notice that the tileMatrixSet has tileWidth and tileHeight set to 512
But, catalogItem.tileWidth and catalogItem.tileHeight are still set to the default value 256

Because of nullish coalescing (??) order here:

terriajs/lib/Models/Catalog/Ows/WebMapTileServiceCatalogItem.ts

Lines 545 to 549 in e6ec10a

    
           minimumLevel: this.minimumLevel ?? tileMatrixSet.minLevel, 
        
           maximumLevel: this.maximumLevel ?? tileMatrixSet.maxLevel, 
        
           tileWidth: this.tileWidth ?? tileMatrixSet.tileWidth, 
        
           tileHeight: 
        
             this.tileHeight ?? this.minimumLevel ?? tileMatrixSet.tileHeight,

(I think there is also a mistake where this.minimumLevel is being used to set tileHeight

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment