Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Losing Z values when multiple KML files are overlaid #6799

Closed
imakihi opened this issue Jun 7, 2023 · 7 comments · May be fixed by #6952
Closed

Losing Z values when multiple KML files are overlaid #6799

imakihi opened this issue Jun 7, 2023 · 7 comments · May be fixed by #6952
Assignees
@nf-s

Comments

@imakihi
Copy link
Contributor

imakihi commented Jun 7, 2023

When I drag and drop the same KML file twice, then it looks like the second data lose the Z value on the map.
In the following image and video, those two triangles are the exactly the same KML data. I added #1 first followd by #2.
I attached the KML file I tested.

image
test.zip

2023-06-06_12-08-06.1.1.mp4
@imakihi
Copy link
Contributor Author

imakihi commented Jun 22, 2023 •
edited

I realized that this doesn't happen on https://vic.digitaltwin.terria.io/
image

@imakihi
Copy link
Contributor Author

imakihi commented Jun 22, 2023

And it always appeard as flat polygon on https://nsw.digitaltwin.terria.io/
image

@imakihi
Copy link
Contributor Author

imakihi commented Aug 3, 2023

So, I tested ver 8.3.0 and I didn't see this issue. So, I guess this issue is resolved in the latest version.
So, I am going to close this.
Thank you!!
Hiroo

@imakihi imakihi closed this as completed Aug 3, 2023
@imakihi imakihi reopened this Oct 4, 2023
@imakihi
Copy link
Contributor Author

imakihi commented Oct 4, 2023 •
edited

Hi there. I need to reopen this issue.
After we examined various Terria sites, only the Victoria site doesn't have this problem. We tested TerriaJS 3.2.X, 8.3.2 and 8.3.3 but they all had this issue.

Issue:
When I locally import KML files twice, KML layers lose their hight (z). Sometime, KML layers are showed as 2D polygon in the 3D mode.

To replicate this issue, please locally import KML polygons. Here is my sample data (you need to change its extension to .kml).
test_polygon.txt

Here is the version of Victoria instance
image

We tried this version
image

and others. When you load this data in the 2D mode and change to the 3D mode, it shows as 3D geometry but if you import the same KML again, it become 2D polygon.

It would be great if someone can find the solution.

Thanks.

@nf-s nf-s mentioned this issue Oct 25, 2023
Open
4 tasks
@nf-s
Copy link
Contributor

nf-s commented Oct 25, 2023

Hi @imakihi

Please see my PR here and let me know if that fixes your issue

@imakihi
Copy link
Contributor Author

imakihi commented Oct 25, 2023

Hi Nick. Thank you for working on this. I will check this shortly.
Best regards.
Hiroo

@nf-s nf-s self-assigned this Nov 1, 2023
@imakihi
Copy link
Contributor Author

imakihi commented Nov 5, 2023

@nf-s
It worked!! Thank you for this!!!!!!
Best. Hiroo

@imakihi imakihi closed this as completed Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nf-s nf-s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add clampToGround to kml TerriaJS/terriajs
2 participants
@imakihi @nf-s