Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null/inverse selection color #136

Open
jpnurmi opened this issue Sep 27, 2022 · 3 comments
Open

Null/inverse selection color #136

jpnurmi opened this issue Sep 27, 2022 · 3 comments
Assignees

Comments

@jpnurmi
Copy link
Contributor

jpnurmi commented Sep 27, 2022

Would it be possible to make the selection color nullable and draw selected cells inverted when the selection color is null?

gnome-terminal-selection.webm
@jpnurmi
Copy link
Contributor Author

jpnurmi commented Sep 27, 2022

P.S. Perhaps the same approach could work for the cursor color too?

@jpnurmi
Copy link
Contributor Author

jpnurmi commented Sep 27, 2022

P.P.S. In fact, the GNOME terminal uses inverse colors even for search. This way, you never end up with unreadable colors.

@jpnurmi
Copy link
Contributor Author

jpnurmi commented Sep 27, 2022

Here's a quick and dirty proof of concept with xterm.dart. If a cell is selected, toggle its inverse flag. If it has cursor, toggle the inverse flag again.

xterm-inverse-cursor-selection-color.webm

jpnurmi added a commit to jpnurmi/xterm.dart that referenced this issue Sep 28, 2022
@xtyxtyx xtyxtyx self-assigned this Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants