Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have you ever ran eslint on the JavaScript generated code ? #287

Open
fungiboletus opened this issue Oct 17, 2019 · 1 comment
Open

Have you ever ran eslint on the JavaScript generated code ? #287

fungiboletus opened this issue Oct 17, 2019 · 1 comment

Comments

@fungiboletus
Copy link
Contributor

We did for some reasons.

I think we could take a look at the advice from eslint :

eqeqeq to have safer comparisons.
func-names to have better debug traces.

Otherwise once we disable the eslint warnings that we will never fix because it's generated code, it's not so bad. It actually found real errors in the generated code.

@brice-morin
Copy link
Collaborator

It would be good if you could run the linter, configured to report only the errors/warnings that you think shoud be fixed, on https://github.com/SINTEF-9012/thingml-diversifier/blob/master/src/main/resources/experiments1/nodejs.thingml

And provide me with the report, then I can have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants