Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error handling behaviour #1106

Open
karb0f0s opened this issue Jan 31, 2022 · 4 comments · May be fixed by #1343
Open

Change error handling behaviour #1106

karb0f0s opened this issue Jan 31, 2022 · 4 comments · May be fixed by #1343

Comments

@karb0f0s
Copy link
Member

karb0f0s commented Jan 31, 2022

Consider capturing exceptions in Event Handler and forwarding them to Error Handler.

@tuscen tuscen transferred this issue from TelegramBots/Telegram.Bot.Extensions.Polling Jun 18, 2022
@dezared
Copy link

dezared commented Sep 3, 2023

a fix is ​​planned, a possible solution to this problem? I don't want the bot to shut down due to an error

@Fedorus
Copy link
Member

Fedorus commented Sep 3, 2023

@dezared you should handle errors of your code yourself

@Fedorus Fedorus closed this as completed Sep 3, 2023
@karb0f0s karb0f0s reopened this Sep 3, 2023
@karb0f0s
Copy link
Member Author

karb0f0s commented Sep 3, 2023

We are prototyping it in a separate branch, but, unfortunately, there's no milestone for this feature.

karb0f0s added a commit that referenced this issue Jan 10, 2024
@karb0f0s karb0f0s linked a pull request Jan 10, 2024 that will close this issue
@rivancic
Copy link

rivancic commented Mar 9, 2024

@dezared you should handle errors of your code yourself

This is like saying if you integrate a library in your backend application at a bank, and you send wrong request, instead of getting 400 or 404 HTTP message that you then handle or exception for that matter and continue with your logic instead this will cause your library to not respond anymore until you restart your whole service.
It doesn't make sense to me, or I'm missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants