Skip to content
This repository has been archived by the owner on Jan 1, 2022. It is now read-only.

Refactoring the CommandBase #8

Open
poulad opened this issue Aug 27, 2017 · 0 comments
Open

Refactoring the CommandBase #8

poulad opened this issue Aug 27, 2017 · 0 comments
Labels
Milestone

Comments

@poulad
Copy link
Member

poulad commented Aug 27, 2017

Methods of a command class (canHandle, parse, handle) should only get a Message as input not the Update because it could be confusing to the user.

Also, updates of types other than [Edited]MessageUpdate are never considered as command.

btw, CommandBase.CanHandleCommand doesn't need to be virtual.

@poulad poulad added the bug label Aug 27, 2017
@poulad poulad added this to the v2.0.0 milestone Aug 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant