Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unintended Deletion of Other Containers During Benchmarking: Normal or Error ? #8125

Open
jeffersonjpr opened this issue Apr 4, 2023 · 2 comments

Comments

@jeffersonjpr
Copy link

After running the benchmarks, I noticed that other containers had been deleted. I'm not sure if this is normal or if I did something wrong, as I couldn't find anything in the readme or wiki that suggested this would happen to other containers as well.

OS

image

Steps to reproduce behavior

I executed the quick start Quick Start Guide

@NateBrady23
Copy link
Member

That shouldn't be the case. Were you able to reproduce this a few times? The status of your container was exited already?

The code in the toolset seems to be only stopping containers with techempower in the image tags:

    @staticmethod
    def __stop_all(docker_client):
        for container in docker_client.containers.list():
            if len(container.image.tags) > 0 \
                    and 'techempower' in container.image.tags[0] \
                    and 'tfb:latest' not in container.image.tags[0]:
                DockerHelper.__stop_container(container)

but might be happening elsewhere. I'll try and reproduce this when I can.

@jeffersonjpr
Copy link
Author

It only happened once. I began monitoring the benchmark using docker ps while also keeping an eye on my computer's performance with htop. I did not use any docker commands while the benchmark was running. After the benchmark completed, I ran docker ps -a to check if the cleaning process was successful and confirmed that there were no containers left. However, I noticed that my metabase container was missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants