Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurability to Java benchmarks #8029

Open
calderast opened this issue Mar 14, 2023 · 1 comment
Open

Add configurability to Java benchmarks #8029

calderast opened this issue Mar 14, 2023 · 1 comment

Comments

@calderast
Copy link
Contributor

The Java Engineering team at Microsoft is using some of the TechEmpower framework benchmarks to test the performance of our JDK.
We've run into a few places where it would be helpful to add configurability to the Java benchmarks:

  • It would be helpful to be able specify the JDK under test
  • It would be helpful to be able to append JVM arguments/override existing JVM arguments (see example here for the spring benchmark)
  • It would be helpful for the user to be able to specify extra docker arguments (I submitted PR Add option for extra docker args to tfb script #7977 for this, but after a second look I'm not sure if those args actually go to to the docker container under test, or just an intermediate container)

Please let me know if you have any thoughts on how to tackle these issues in a way that would benefit everyone using these benchmarks!

@NateBrady23
Copy link
Member

NateBrady23 commented Mar 14, 2023

Ah, yes. Now that I think about it, those args are just getting tossed to the toolset container.

I think what would need to happen is a new toolset arg here to pass docker arguments to the test docker container.

We don't have any bandwidth to add new features to the toolset right now, but certainly if somebody wants to tackle this, I'll give guidance where I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants