Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Several Item Name Issues & other #304

Open
1 task done
rafaelantunes04 opened this issue Mar 24, 2024 · 1 comment
Open
1 task done

[Bug]: Several Item Name Issues & other #304

rafaelantunes04 opened this issue Mar 24, 2024 · 1 comment
Assignees
Labels
Bug A feature of the mod doesn't work properly, causes a crash, etc.

Comments

@rafaelantunes04
Copy link

Initial Check

  • I have checked the existing issues and this one is not a duplicate

Category

馃ОItems

Description

MC version: 1.12.2
Forge version: 14.23.5.2859
Mod version: 0.3.0
Lang: English (US)

Disclaimer
Content here is written to improve the mod and refine it in some ways, since the mod with the right dedication and community has a bright future ahead.
Some of these might be feature, but i since i dont know i prefer sharing instead of this being unknown.
Im going to start a bit of topic with a slight off topic request since i cant select bug and ask for feature request (Only for refining mod).
Im know how to program, but i'm not very proficient in Java but with more effort into it i think i can solve this problem. I have a bit of spare time to try my best at Team Immersive Intelligence, so feel free to contact me if interested in an extra pair of hands, even if only for testing and opinion.

Changes

Drill Heads Change
Since i dont have tinkers installed, i think it becomes a bit weird for drill mining levels to be thinkers instead of vanilla's.

  • Diamond-Tipped Iron Drill Head: Mining level is obsidian being obsidian becomes weird, imo diamond becomes a better choice since it describes well what it can mine (the same as a diamond pickaxe)

  • Diamond-Tipped Steel Drill Head & Tungsten Drill Head: Mining level is cobalt and as i told earlier, it becomes weird, if changed to diamond when tinkers isnt installed will make more sense.

  • Diamond-Tipped Tungsten Drill Head: The same but with Manyullyn.

imagem

Add Jei support
-As the title say, this could help in the case of someone is lost in trying to craft something, adding a better user experience.

Bugs

Now on the actual name bug report (dont know if its feature or not):

Artillery Shells

  • "Phosphorgranate mk.1", "Napalmgranate mk.1" and "Geburtsgtagsgranate mk.1: Names are exactly as written here for these artillery shells, and in the inventory tab they are separated from the other shells, after the mortar shells, becoming a bit weird.

imagem

Hand Grenades And Railgun Grenades

  • "Chemhandgranate mk.1", "Sprenghandgranate mk.1", "Sprenghandgranate mk.2", "Stielhandgranate mk.1", "Phosphorhandgranate mk.1", "Feuerwerkhandgranate mk.1": Names are exactly as written here for these hand grenades, and goes the same for the inventory tab, being the last one separated from the other hand grenades.

  • "Schienenkanone Chemgranate mk.1", "Schienenkanone Sprenggranate mk.1": Names are exactly as written here for these railgun grenades.

imagem

Bullets & related

  • "Flammpatrone mk.1", "Wolframpatrone mk.1" (revolver), "Markierungpatrone mk.1", "Sprengpatrone mk.1", "Wolframpatrone mk.1" (machinegun)", "Stahlpatrone mk.1", "Phosphorpatrone mk.1", "Uraniumpatrone mk.1": Names are exactly as written here for these bullets, and in the inventory tab the "Uraniumpatrone mk.1" is separated from the other bullets, by two magazines, becoming a bit weird.

  • Magazines right after the bullets: This might be solved by correcting the names, but the magazines after the bullets referenced before have the same names of the bullets in the description, with some having bullet names i cant even find using Jei, such as "Limemarkierungpatrone", being completely unaware of how to make these.

imagem

Misc

  • "Seemine mk.1": Name of the item as written here, and in the description two spaces in the "Fitted with**__**Brass Core".

  • "Radio-Sprengstoff TNT mk.1": Name of the item as written here, and in the description two spaces in the "Fitted with**__**Brass Core".

  • "Radio-Sprengstoff Phosphor mk.1": Name of the item as written here, and in the description two spaces in the "Fitted with**__**Brass Core".

  • "Tellermine mk.1": Name of the item as written here, and in the description two spaces in the "Fitted with**__**Brass Core".

  • "SD-Mine mk.1": Name of the item as written here, and in the description two spaces in the "Fitted with**__**Brass Core".

imagem

PS: Hope this Issue might help the development of the mod in any kind of way.

Side

Client

Reproduction

MC version: 1.12.2
Forge version: 14.23.5.2859
Mod version: 0.3.0
Lang: English (US)

Expected Behaviour

Have the correct names of the corresponding language.

Logs

No response

Other Evidence

No response

Operating System

Windows 10 or newer

Minecraft Version

1.12.2

Immersive Intelligence Version

0.3.0 (Recent Dev Build)

Immersive Engineering Version

0.98

@rafaelantunes04 rafaelantunes04 added the Bug A feature of the mod doesn't work properly, causes a crash, etc. label Mar 24, 2024
@Pabilo8 Pabilo8 assigned Pabilo8 and unassigned CarverBot Mar 25, 2024
@Pabilo8 Pabilo8 added this to the Factory Refurbishment (0.3.0) milestone Mar 25, 2024
@Pabilo8
Copy link
Member

Pabilo8 commented Mar 25, 2024

Thanks for the report, will address the points below:

  • tipped drill mining levels - These mining level names are defined in IE's lang file, but were unused. If you want to change them you can edit the lang file (resourcepack) or use crafttweaker to overwrite the translations.
  • II supports JEI in most of its production machines, 0.3.1 will also add JEI support for ammo production machines
  • the colored bullets are intentionally not listed (so it doesn't flood the inventory); they all have a brass core and a tracer powder component colored red, yellow, blue or green and are repeated, so they fill the entire magazine
  • never gave it too much thought, but as you've shown, the ammo order is weird at places, I'll make it more organised soon

@Avalon2106 Avalon2106 assigned Avalon2106 and Pabilo8 and unassigned Pabilo8 May 7, 2024
@Avalon2106 Avalon2106 removed their assignment May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A feature of the mod doesn't work properly, causes a crash, etc.
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants