Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GalleryProcessor vs. FilesProcessor options #617

Open
kitzberger opened this issue Jul 13, 2023 · 1 comment
Open

GalleryProcessor vs. FilesProcessor options #617

kitzberger opened this issue Jul 13, 2023 · 1 comment

Comments

@kitzberger
Copy link
Contributor

kitzberger commented Jul 13, 2023

The options of GalleryProcessor and FilesProcessor aren't really documented at the moment. I'd like to change that, but I'm afraid I need some input first ;-)

See PR #618 for an image documentation.

Question 1: what's the FilesProcessor option delayProcessing for?

Is it used to skip image processing in FilesProcessor and let the 2nd data processor GalleryProcessor do that?

✔️ Yes.

Question 2: is GalleryProcessor not supporting fileExtension yet?

Since #498 it's possible to specify a custom image format (e.g. webp) and the rendered image is being converted to that format.

🌱 See PR #619 for the solution.

Question 3: should we make the autogenerate option configurable?

Currently the option autogenerate has two hardcoded sub-options: retina2x and lqip. If activated additional image URIs are being rendered for which constants from FileUtility are used to calculate the width and height of that 'variants'.

In both FilesProcessor and GalleryProcessor it's basically the same code to do that. The only difference is that GalleryProcessor doesn't pass along other options like fileExtension.

Maybe those parts could be refactored to be entirely configurable via TypoScript?

🌱 See PR #620 for the solution.

@twoldanski
Copy link
Collaborator

Hi,
Q1: Yes, this is performance flag to inform FilesProcessor only to collect files and then pass them to GalleryProcessor in order to avoid double processing of the same files (first in FileProcessor and then again in GalleryProcessor)
Q2: No, currently not supporting it.
Q3: Of course we could, but you have some use case for it?

twoldanski added a commit that referenced this issue May 9, 2024
- new simplified output (off by default)
- new options to process files (custom autogenerate feature), filter & alias properties for much cleaned up output. Useful with large sites with a lot of images on page. See options Documentation/Developer/Images.rst
- code refactoring
- allows to process more image formats

Resolves: #247, #617
twoldanski added a commit that referenced this issue May 9, 2024
- new simplified output (off by default)
- new options to process files (custom autogenerate feature), filter & alias properties for much cleaned up output. Useful with large sites with a lot of images on page. See options Documentation/Developer/Images.rst
- code refactoring
- allows to process more image formats

Resolves: #247, #617
lukaszuznanski pushed a commit that referenced this issue May 10, 2024
- new simplified output (off by default)
- new options to process files (custom autogenerate feature), filter & alias properties for much cleaned up output. Useful with large sites with a lot of images on page. See options Documentation/Developer/Images.rst
- code refactoring
- allows to process more image formats

Resolves: #247, #617
twoldanski added a commit that referenced this issue May 10, 2024
- new simplified output (off by default)
- new options to process files (custom autogenerate feature), filter & alias properties for much cleaned up output. Useful with large sites with a lot of images on page. See options Documentation/Developer/Images.rst
- code refactoring
- allows to process more image formats
- add additional tests

Resolves: #247, #617
lukaszuznanski pushed a commit that referenced this issue May 13, 2024
* [FEATURE] Improve file processing

- new simplified output (off by default)
- new options to process files (custom autogenerate feature), filter & alias properties for much cleaned up output. Useful with large sites with a lot of images on page. See options Documentation/Developer/Images.rst
- code refactoring
- allows to process more image formats

Resolves: #247, #617

* [FEATURE] Improve file processing

- new simplified output (off by default)
- new options to process files (custom autogenerate feature), filter & alias properties for much cleaned up output. Useful with large sites with a lot of images on page. See options Documentation/Developer/Images.rst
- code refactoring
- allows to process more image formats
- add additional tests

Resolves: #247, #617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants