-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GalleryProcessor vs. FilesProcessor options #617
Comments
This was referenced Jul 13, 2023
Hi, |
twoldanski
added a commit
that referenced
this issue
May 9, 2024
- new simplified output (off by default) - new options to process files (custom autogenerate feature), filter & alias properties for much cleaned up output. Useful with large sites with a lot of images on page. See options Documentation/Developer/Images.rst - code refactoring - allows to process more image formats Resolves: #247, #617
twoldanski
added a commit
that referenced
this issue
May 9, 2024
- new simplified output (off by default) - new options to process files (custom autogenerate feature), filter & alias properties for much cleaned up output. Useful with large sites with a lot of images on page. See options Documentation/Developer/Images.rst - code refactoring - allows to process more image formats Resolves: #247, #617
lukaszuznanski
pushed a commit
that referenced
this issue
May 10, 2024
- new simplified output (off by default) - new options to process files (custom autogenerate feature), filter & alias properties for much cleaned up output. Useful with large sites with a lot of images on page. See options Documentation/Developer/Images.rst - code refactoring - allows to process more image formats Resolves: #247, #617
twoldanski
added a commit
that referenced
this issue
May 10, 2024
- new simplified output (off by default) - new options to process files (custom autogenerate feature), filter & alias properties for much cleaned up output. Useful with large sites with a lot of images on page. See options Documentation/Developer/Images.rst - code refactoring - allows to process more image formats - add additional tests Resolves: #247, #617
lukaszuznanski
pushed a commit
that referenced
this issue
May 13, 2024
* [FEATURE] Improve file processing - new simplified output (off by default) - new options to process files (custom autogenerate feature), filter & alias properties for much cleaned up output. Useful with large sites with a lot of images on page. See options Documentation/Developer/Images.rst - code refactoring - allows to process more image formats Resolves: #247, #617 * [FEATURE] Improve file processing - new simplified output (off by default) - new options to process files (custom autogenerate feature), filter & alias properties for much cleaned up output. Useful with large sites with a lot of images on page. See options Documentation/Developer/Images.rst - code refactoring - allows to process more image formats - add additional tests Resolves: #247, #617
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The options of
GalleryProcessor
andFilesProcessor
aren't really documented at the moment. I'd like to change that, but I'm afraid I need some input first ;-)See PR #618 for an image documentation.
Question 1: what's the
FilesProcessor
optiondelayProcessing
for?Is it used to skip image processing in
FilesProcessor
and let the 2nd data processorGalleryProcessor
do that?✔️ Yes.
Question 2: is
GalleryProcessor
not supportingfileExtension
yet?Since #498 it's possible to specify a custom image format (e.g.
webp
) and the rendered image is being converted to that format.🌱 See PR #619 for the solution.
Question 3: should we make the
autogenerate
option configurable?Currently the option
autogenerate
has two hardcoded sub-options:retina2x
andlqip
. If activated additional image URIs are being rendered for which constants fromFileUtility
are used to calculate the width and height of that 'variants'.In both
FilesProcessor
andGalleryProcessor
it's basically the same code to do that. The only difference is thatGalleryProcessor
doesn't pass along other options likefileExtension
.Maybe those parts could be refactored to be entirely configurable via TypoScript?
🌱 See PR #620 for the solution.
The text was updated successfully, but these errors were encountered: