Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#122] renders all data that comes from dataProcessor #162

Closed
wants to merge 3 commits into from

Conversation

gordon81
Copy link

@gordon81 gordon81 commented Jul 9, 2020

Resolves #122

@lukaszuznanski
Copy link
Collaborator

need to resolve merge conflict

@lukaszuznanski
Copy link
Collaborator

Looks fine so far, but we need to keep old behavior when we have "as" set.

@gordon81
Copy link
Author

if "as" set it work or "as" as "key"

JsonContentObject row 162 to $dataProcessingData['value'] =$data[$value];

but this breaks Frontend

@lukaszuznanski
Copy link
Collaborator

I think this should be adapted to new JsonContentObject version. If you want to keep this functionality, please create new PR with your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dataProcessor returning empty array if no "as" conf value found in typoscript
3 participants