Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSAF SMDAS SWI #43

Open
wpreimes opened this issue Sep 21, 2020 · 9 comments
Open

HSAF SMDAS SWI #43

wpreimes opened this issue Sep 21, 2020 · 9 comments

Comments

@wpreimes
Copy link
Member

Do you want to include the SMDAS data reader in this package? https://github.com/wpreimes/ascat/blob/smdas_reader/src/ascat/smdas.py

Then I'll fix some issues, clean up, write tests etc for it.

The data itself is a bit awkward, corrupt files, missing variables, deviating time stamps in metadata and filename etc.
Therefore the reader is also a bit messy...

@sebhahn
Copy link
Member

sebhahn commented Sep 21, 2020

Which products do you mean by SMDAS exactly?

@wpreimes
Copy link
Member Author

H-SAF SM-DAS-2 H-14 root zone soil moisture index product, based on ASCAT surface soil moisture data assimilation in the ECMWF Land Data Assimilation System

@sebhahn
Copy link
Member

sebhahn commented Sep 21, 2020

Yes it makes sense to add a reader, but sooner or later it this should be moved to its own package here https://github.com/H-SAF

@sebhahn
Copy link
Member

sebhahn commented Sep 21, 2020

Same for all other H SAF SM products

@wpreimes
Copy link
Member Author

If you want I can make a new package for the SMDAS data now already. Just tell me what you prefer.

@sebhahn
Copy link
Member

sebhahn commented Sep 21, 2020

Probably it makes sense to start with a new package, but I wouldn't call it SMDAS.

However, first I need to think about how to structure the packages in H SAF (package per product, package per variable, ...). What would you prefer as a user?

@sebhahn
Copy link
Member

sebhahn commented Sep 21, 2020

@davidfairbairn do you have an opinion how to structure the python packages on H SAF?

@wpreimes
Copy link
Member Author

From a user perspective it would be nice to have everything in one place. But from a developer point of view I think a package per product makes more sense than a package per variable, because of different file types, dependencies, resolutions etc. So maybe multiple smaller readers and one toolbox to collect them?

@sebhahn
Copy link
Member

sebhahn commented Sep 21, 2020

I like the idea with the toolbox, but typically products are quite similar in their format, type, etc. so probably a package per variable makes more sense? surface soil moisture and root zone soil moisture separated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants