Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] ForceForeground setting condition is not used internally #283

Open
ferpasri opened this issue Oct 1, 2021 · 2 comments
Open

Comments

@ferpasri
Copy link
Member

ferpasri commented Oct 1, 2021

Right now we are always forcing the SUT to the foreground without using the ForceForeground test.setting

// If the system is in the background, we need to force it into the foreground!

// If the system is in the background, we need to force it into the foreground!
// We set this.forceToForeground to true and selectAction will make sure that the next action we will select
// is putting the SUT back into the foreground.
if(!state.get(Tags.Foreground, true) && system.get(Tags.SystemActivator, null) != null){
	this.forceToForeground = true;
	return actions;
}

Add this setting as a condition or remove from ConfigTags if is not used.

// If the system is in the background, we need to force it into the foreground!
// We set this.forceToForeground to true and selectAction will make sure that the next action we will select
// is putting the SUT back into the foreground.
if(!state.get(Tags.Foreground, true) && system.get(Tags.SystemActivator, null) != null && settings.get(ConfigTags.ForceForeground, false)){
	this.forceToForeground = true;
	return actions;
}
@pekkakaho
Copy link
Member

To be considered, whether there is a use case when we don't want to bring the SUT to the foreground.

Also, another discussion is how force to foreground implementation works...

@ferpasri ferpasri changed the title ForceForeground setting condition is not used internally [Refactor] ForceForeground setting condition is not used internally Dec 20, 2022
@ferpasri
Copy link
Member Author

Refactor the ForceForeground ConfigTag to allow users to select how to put the system in the foreground. Also, take into consideration the different OS (Windows, MacOS, etc...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants