-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect MIN Python Version in README #957
Comments
Hmm, that's a good point. It's probably a good idea to update it. To some extent, STUMPY technically still supports Python 3.7 but only for older STUMPY versions. However, this is confusing and it is better to be consistent and update everything to We should add "f) README.md" to the comments of the Lines 7 to 12 in 3da1500
Indeed. I have added #958 (and corresponding |
Hey All - hope you're having a wonderful day! Would it be alright if I take this one? I'm new to OSS contributions, but want to help! |
@joehiggi1758 Thank you for your interest in contributing to STUMPY. Yes, please feel free to take this one! It looks like we need:
Please do not hesitate to ask any questions and take a look at our Contributors Guide for a good place to start (that document might need some love too as it might be outdated). |
@seanlaw thanks so much for the opportunity to help, I'm on it!
Will try to knock this one out by end of week! |
So, the pypi.sh file is a simple helper script that we use to help us upload the latest package version to PyPI. Since this uploading task is only performed once in a while, we also store "last minute steps" (as comments) in this file to remind us of the additional things that we need to check off our list BEFORE we upload to PyPI. In this particular case, we should add
Currently, the list ends at Actually, I just realized that we no longer have a setup.py file (since we migrated over to using a
|
@joehiggi1758 Once this is done then somebody can work on issue #973, which is somewhat related to this |
@seanlaw sounds great! I'd be happy to snag #973 if nobody else has (after I close this one out)! Apologies for the likely naïve question - but I can't seem to get my local repository to pass the full set of tests in "test.sh" and keep getting the following. I've followed the Stumpy setup docs exactly and have tried everything I can think of - any direction on how to clear would be much appreciated! |
Not naive at all! Let's try to figure this out together and maybe update the Contributors Guide if we're missing anything obvious. Sometimes, it's a matter of figuring out how things work on different development environments.
Hmmm, a couple of things:
In other words, STUMPY should only have around 86 files that would be checked by |
@seanlaw thank you very much for the direction here - it was super helpful! I figured out the issue - and I do believe this warrants an update to the 'Contributing Guide' and perhaps an update to 'test.sh'. I had cloned STUMPY locally to my installation of MS VS Code (not using Anaconda), and when I would run 'test.sh' in the STUMPY root directory, it would actually look through my virtual environment (which I had called .venv) and run tests on all files contained, including isolated package installations, hence why my file count was insanely high ~2900 in the above output. I switched to using Anaconda and was able to get everything working - I have submitted a pull request for the above! I'm open to any and all feedback as I'm eager to learn, please let me know how I can improve moving forward! Once this issue closes, I will happily pick up #973 if it's still open! |
Hmm, I've not used FYI, I am trying to determine if the "problem" is actually coming from VSCode or from
Sounds good! Let's leave #973 last (as it is more complex) and handle this issue as well as #975 first. |
No, thank YOU! Sometimes, contributing (to Python packages) can be front loaded with frustrating issues like this that have nothing to do with the actual Python coding and many people quit due to how daunting it feels. So, your persistence is greatly appreciated!
@joehiggi1758 You have the right mindset so let's learn and make progress together! :) |
…UMPY supports Python 3.8+ updated pypi.sh to reference step a) pyproject.toml instead of the decomissioned setup.py and ultimately scanned the full repository for any listings of outdated references to STUMPY supporting Python 3.7 (I was unable to find any)
The MIN Python version mentioned In
README.rst
is outdated (see the following line)Is it okay to just change it to
3.8+
? Because STUMPY has not tested the support forpython 3.12
yet in.github/workflows/github-actions.yml
.The text was updated successfully, but these errors were encountered: