Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forcibly load a collection #388

Open
damianam opened this issue Nov 8, 2018 · 3 comments
Open

Forcibly load a collection #388

damianam opened this issue Nov 8, 2018 · 3 comments

Comments

@damianam
Copy link
Contributor

damianam commented Nov 8, 2018

A user complained because his collection broke and his jobs failed. The collection broke because we changed one module to have

if not isloaded("one_module/.version") then
    load("one_module/.version")
end

instead of

if not isloaded("one_module/version") then
    load("one_module/version")
end

Naïvely, I would say it makes sense to allow --force restore, to forcibly load a collection even if it "appears" broken. Of course it is a dangerous option depending on the changes. But I guess just going through the list of modules in the collection and try to load them should be allowed. If the load fails and the environment is broken, then so be it, those are the risks of --force. Any comments?

@kayleanelson
Copy link

kayleanelson commented Jan 2, 2020

I was wondering if there were any thoughts on this issue? We also face job failures with collections "breaking" when changes have been made to a module and it would be great to be able to forcibly load the collection.

@kayleanelson
Copy link

Hello. This just tripped our users up again. Is there any consideration for adding a "--force" flag?

@rtmclay
Copy link
Member

rtmclay commented Jan 18, 2024

This is not happening. There is no way to make this work reliably. You get a failure from loading a collection when loading the modules in a collection by hand is different from loading module collections. Not only that, there is no feedback to the user that it failed and the collection has to be rebuilt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants