Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to OpenAPI spec as API source of truth #2752

Open
finestructure opened this issue Dec 1, 2023 · 1 comment
Open

Move to OpenAPI spec as API source of truth #2752

finestructure opened this issue Dec 1, 2023 · 1 comment
Assignees

Comments

@finestructure
Copy link
Member

We've uncovered some issues with generating the OpenAPI spec from VaporToOpenAPI annotations. We're also blocked from bumping this dependency to the next major release due to a compile error.

Finally, Honza makes some great points why starting from the OpenAPI spec as the source of truth is good best practise.

We should take a stab at switching to this approach.

@finestructure finestructure self-assigned this Dec 1, 2023
@heckj
Copy link
Sponsor Collaborator

heckj commented Dec 1, 2023

I guess I shouldn't continue to babble away on a closed issue, huh? ;-)

As a related note, the VaporToOpenAPI issue might be resolved with a version update to 4.4.3 per dankinsoid/VaporToOpenAPI#17 (although it might also require an update to an example declaration - uncertain there, but I'll try and look)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants