Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

ILogger support for the REST & RPC drivers #65

Open
ProphetLamb opened this issue Sep 27, 2022 · 0 comments
Open

ILogger support for the REST & RPC drivers #65

ProphetLamb opened this issue Sep 27, 2022 · 0 comments
Labels
feature New feature or request hacktoberfest

Comments

@ProphetLamb
Copy link
Collaborator

ProphetLamb commented Sep 27, 2022

The database drivers DatabaseRest and DatabaseRpc should have a property, initialized from .ctor of the type ILogger Logger.

LoggerMessages should be defined using the LoggerMessageGenerator.

The content, for each logging level, should be reasonable. Here are a few examples:

Verbosity Example
Debug Each public method call. e.g. Query, SignUp. The query itself, such as credentials, must never be logged!
Info Significant state changed Open, Close.
Warning Duplicate call to open, empty results etc.
Error Exceptions, failed to open etc.

These are mostly how I personally feel about logging verbosity, feel free to choose differently, within reason.

@ProphetLamb ProphetLamb added feature New feature or request feedback-needed This issue or the solution requires feedback labels Sep 27, 2022
@ProphetLamb ProphetLamb added hacktoberfest and removed feedback-needed This issue or the solution requires feedback labels Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request hacktoberfest
Projects
None yet
Development

No branches or pull requests

1 participant