Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCPH-1150 rumble #23

Open
sonik-br opened this issue Feb 28, 2023 · 4 comments
Open

SCPH-1150 rumble #23

sonik-br opened this issue Feb 28, 2023 · 4 comments

Comments

@sonik-br
Copy link

Hi!

The japanese SCPH-1150 dual analog controller features a primitive type of rumble.
It uses single motor with only on/off state and does not support any kind of configuration command. So no need to "enable rumble".

I don't have access to this model of controller but the DualShock is backward compatible with this old rumble mode.
I've added support for this type of rumble and it's working with a DualShock. I can submit a PR with the code change.

BTW I've also added support for the jogcon's motors long ago. Been using it for years now. Should I submit a PR for it too?
I would ask you to take a look if you see a better way to implement it and to fit the lib's coding style.

@SukkoPera
Copy link
Owner

Hi, yes, feel free to submit PRs for everything! I'd really like to keep a single library with all the features rather then having a number of different, incompatible libraries. I am not working on this at the moment, but I promise I'll merge everything, one day :).

Just submit several PRs if you can though, one for every feature. This would help a lot.

@sonik-br
Copy link
Author

Cool. Will do.
Might be complex to do multiple PRs but I will try. Both features need to change how the rumble command works.

@SukkoPera
Copy link
Owner

Well, one will be fine too then!

@sonik-br
Copy link
Author

sonik-br commented Mar 2, 2023

Got it in multiple PRs. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants