Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot remove a song's rating #198

Open
Khazbs opened this issue Feb 20, 2024 · 2 comments
Open

Cannot remove a song's rating #198

Khazbs opened this issue Feb 20, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Khazbs
Copy link

Khazbs commented Feb 20, 2024

Describe the bug
Accidentally clicked on the stars and added a rating to a song, now I cannot remove the rating neither by clicking the same star in Submariner, nor by removing it in Navidrome directly and hitting ⌘R in Submariner.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a Navidrome server library;
  2. Open an album;
  3. Select a song;
  4. Click any of the five stars to add a rating;
  5. Click the same star attempting to remove the rating;
  6. Scratch your head in confusion.

Expected behavior
It should be possible to remove the rating by clicking the star that corresponds to the current rating.

Screenshots
Submariner screenshot with two songs rated 5 stars

Versions:

  • macOS Sonoma v. 14.3.1;
  • Navidrome v. 0.49.3;
  • Submariner v. 3.0;
  • Installed as a Homebrew Cask.

Additional context
P.s. Off We Go Into the Wild Pale Yonder indeed

@Khazbs Khazbs added the bug Something isn't working label Feb 20, 2024
@NattyNarwhal
Copy link
Member

NattyNarwhal commented Feb 20, 2024

When you're setting the rating, hold the rating control, and drag it to the left so that it removes all the stars, and release. It should set it to zero. It's not intuitive though, so I agree there should be a more obvious method.

When refreshing, it doesn't actually remove the rating when it becomes unset, and just ignores the lack of it. This is a bug.

NattyNarwhal added a commit that referenced this issue Feb 21, 2024
And be sure to unset too.

Can be cherry-picked back to master

half of GH-198
@Khazbs
Copy link
Author

Khazbs commented Feb 21, 2024

Thank you! Holding the stars and dragging them to the left does the trick indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants