Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDR Support #79

Open
ghost opened this issue Aug 30, 2021 · 3 comments
Open

HDR Support #79

ghost opened this issue Aug 30, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Aug 30, 2021

Hi, I came across a strange behavior. When I play these links using FlyView, the video does not have full color saturation.
When I try to play the same in VLC, the colors are fine.
I don't know if there is an error in FlyView or in the links.

I use Flyleaf v3.3
FFmpeg 4.4-80 I tried it with 4.4-79 same result. https://github.com/BtbN/FFmpeg-Builds/releases

https://storage4.premiumcdn.net/preview/24733673/ZmEu7OcEgHLZtXrUxACyXILMtZ9cnbcZxUPVsxyUEnSOXU3kUvkUNkCpQSDYS8aH4ehmwc1eHMJurbIlrs8Du1OF30iYGS7ZHW8FQ9IReH41IlYtvguxJH13toMu5DCYvug5IzWfwaTrPu9JTNp.mp4?expires=1630370373&hash=Jiq7-gf5fTOMOE2ePWZ21A

https://storage1.premiumcdn.net/preview/24736169/O8kC5BIJDUBgFJXI0GFr9F0ZtaouJMfEeIRvHQGI1kF7zIKXC6JILAHqvFpoCArSY4HjWUDkCmGsOPuJ0sW6SeZcAkIOXhMmha5U4wsz0Sk0CWKuJVUoOf9wtP7tXlHJRu6rURGfa9FnriyEHqk.mp4?expires=1630360913&hash=NY-478b5m9Zp9FL5Ru6YcA

https://storage1.premiumcdn.net/preview/24732113/KPDI6YCarHGwFo2IZMTBbIk9ho0c7vu9xIpwHwLIx4T4bIm9U0AI76HvGTnjUnrH7jH9nfGpUDWiwZcgbsmrSKpi7KUDJhq4h8VfwzUz8SgpUvmcxBfqpCprt34tolHl1cZlfwqCDaTDzFw1HBr.mp4?expires=1630372541&hash=5dgEZL9DyDZ1DTD9NWXzYA

https://storage4.premiumcdn.net/preview/24733778/m83CP9IKBirWIoXcBwsryiMYhX7c5rtnAcr1CB8cJZSAlcm1CbEcj8CDKS46Ud9HjqHR2s6xHqRCJ8i41uo8CMKfbMI0lSD4H6MF8pimrHkXiXmtyeC8zsw0CEBCA2UdVC0aiglfVkUy2CWPU34.mp4?expires=1630360876&hash=-tKJdvpvmoWtSLfp8clPhQ

https://storage4.premiumcdn.net/preview/24730673/4MrfYxtPnsWDTQDFe0igNuQVcLECYVC0yFBkfjEFomILjFeQsX6FQYU5XIG0h2esA3SjrHm2Ip3uA1uy1tvAc39fn9T6EIBPTkQUgLc24s3vS4Dtzkf5NhnPcYXC4XcL3hoysBXC6lcL0fk3frP.mp4?expires=1630362483&hash=v-t3OSU1ZD62cimttsCxuQ

https://storage1.premiumcdn.net/preview/24736475/Xr1Uv6c0KS9xCBKuKqiOzIBvFDWtPpSjMux0H6nupaFrkuDrU3lu1XHBzFYDU0dUYGHx9iOjUJgso6cgYsN0S6zIrZUj0hy2hRdinJUKBSDLU3MsnLiE9fGAtMpt93HRecYwi2riVnFnrC6rHGm.mp4?expires=1630363244&hash=VhiVv0UIZ07pzo5v4NsNxA

img01
img02
img03
img04

@SuRGeoNix
Copy link
Owner

Yep. It's true. I mention that it doesn't support HDR. Not sure if that's HDR or just different color primitives which I've not added yet :(

image

@SuRGeoNix
Copy link
Owner

SuRGeoNix commented Aug 30, 2021

Just tried to force the BT2020 shaders that are included in the library but still same ugly results. I'm not very familiar with HDR and color ranges but I will try to include them soon (might need to replace sharp dx for that, last time failed to enable HDR with sharp dx)

Btw, you should use library's FFmpeg libs. They are patched for HLS and you will not have issues.

@SuRGeoNix SuRGeoNix added the enhancement New feature or request label Aug 30, 2021
@SuRGeoNix SuRGeoNix changed the title Color saturation does not match [Flyleaf v3.3] HDR Support Sep 3, 2021
@SuRGeoNix
Copy link
Owner

Hey @ORRNY66, after replacing SharpDX I was able to look deeper in to this. If you don't have an HDR display v3.3.2 does a very good job with HDR to SDR conversation now. Look also in the video settings for more customization. If you have an HDR you should wait until I will have a spare one as well and add also support for native HDR (which is much easier)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant