Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax theme no longer work #218

Closed
Fubuchi opened this issue Sep 25, 2020 · 3 comments
Closed

Syntax theme no longer work #218

Fubuchi opened this issue Sep 25, 2020 · 3 comments
Labels
bug 🐛 Something isn't working

Comments

@Fubuchi
Copy link

Fubuchi commented Sep 25, 2020

image

@Fubuchi Fubuchi added the bug 🐛 Something isn't working label Sep 25, 2020
@the-j0k3r
Copy link
Member

the-j0k3r commented Sep 25, 2020

Just acknowledging the report, just real life so no time to look at it at the moment.It may take a while to get to this.

A quic look tell me this is now using hljs prefixed classes, we dont have literally any themes with hljs and this undertaking will take a long time to fix, if ever, given my low usage of the sites...

Also if someone contributes a theme they use more often, then it will leave all the others with same issue, so I'll have to consider if syntax themes are worth having at all, its certainly not worth having the majority broken.

That said these new themes could be overriden without any CSS at all, just by overriding the root: values which seem to be only these

--highlight-bg: #1c1b1b;
--highlight-color: #fff;
--highlight-comment: #999;
--highlight-punctuation: #ccc;
--highlight-namespace: #f08d49;
--highlight-attribute: #88aece;
--highlight-literal: #f08d49;
--highlight-symbol: #c59bc1;
--highlight-keyword: #88aece;
--highlight-variable: #b5bd68;
--highlight-addition: var(--green-600);
--highlight-deletion: var(--red-700);

So given this, it would be better to rewrite them, which in any case is no simple undertaking. It would be a better design though.

@the-j0k3r
Copy link
Member

OK Ive done something simple with a couple of preset themes and a custom, Will be removing the built into style because the new design is incompatible with the existing.

the-j0k3r added a commit that referenced this issue Nov 4, 2020
* update readme close #218 (the-j0k3r)
* general fixes (the-j0k3r)
* remove broken themes (the-j0k3r)
* Fix newsletter ad sidebar widget (Fixes #219) (Chris)
@the-j0k3r
Copy link
Member

Consult the readme for instructions.

Any further themes need to be added in same format, the design works, however SO defines which selectors apply, not the theme, any included selectors are to fix some issues with their design and to be compatible with how SO is currently done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants