Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some TimelineItem isn't styled when use the native light theme as a base for GitHub Dark #1290

Open
Geeyun-JY3 opened this issue Jan 10, 2021 · 2 comments
Labels
bug 🐛 Something isn't working

Comments

@Geeyun-JY3
Copy link

  • Browser: Cent Browser 4.3.9.248 (64-bit) (Chromium 86.0.4240.198), Chrome 87.0.4280.141 (Official Build) (64-bit)
  • Operating System: Windows 10 20H2 19042.685
  • Link to page with the issue: user's profile > Contribution activity
  • Screenshot:
    • Join GitHub:
      image
    • Created their first repository:
      image
    • Opened their first issue:
      image
    • Opened their first pull request:
      image
@Geeyun-JY3 Geeyun-JY3 added the bug 🐛 Something isn't working label Jan 10, 2021
@silverwind
Copy link
Member

Generally we recommend dark theme as the base setting in Github. We did invert these timeline images once, I guess the selector for them must have gone stale.

@the-j0k3r
Copy link
Member

Generally we recommend dark theme as the base setting in Github

This is just unwise, especially when the whole ball of yarn was spun around light theme always, and dark theme is not exactly the same in all places.

having said that, youre right these images were fixed by me once, but it would be helpful to have links to these pages not just screenshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants