Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Sponsor Card page is not in dark. #1262

Open
OrigamiDream opened this issue Nov 14, 2020 · 4 comments
Open

GitHub Sponsor Card page is not in dark. #1262

OrigamiDream opened this issue Nov 14, 2020 · 4 comments
Labels
bug 🐛 Something isn't working

Comments

@OrigamiDream
Copy link

스크린샷 2020-11-15 오전 12 47 30

The page can be attached in other pages.

@OrigamiDream OrigamiDream added the bug 🐛 Something isn't working label Nov 14, 2020
@silverwind
Copy link
Member

How are they embedded? iframe?

@xt0rted
Copy link
Member

xt0rted commented Nov 14, 2020

They provide a button and a card that you can embed.

Sponsor button

<iframe src="https://github.com/sponsors/xt0rted/button" title="Sponsor xt0rted" height="35" width="116" style="border: 0;"></iframe>

Sponsor card

<iframe src="https://github.com/sponsors/xt0rted/card" title="Sponsor xt0rted" height="225" width="600" style="border: 0;"></iframe>

@silverwind
Copy link
Member

I see. What's also odd is that black bar on bottom.

I wonder if it's somehow possible to define styles that only apply when a page is iframed. I guess not and we need to match on the URL with a regex rule.

@OrigamiDream
Copy link
Author

Most of user-css extensions (e.g. Cascadea, Stylus) applies the styles recursively.
Therefore you don't need to detect if the page is I-framed.

@silverwind silverwind added bug 🐛 Something isn't working and removed bug 🐛 Something isn't working labels Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants