Sticky header backgrounds

[h1nk]

Sticky header backgrounds are transparent instead of opaque, such as in PRs.

• Browser: Firefox
• Operating System: Linux
• Link to page with the issue: Codemirror tabs #959
• Screenshot:
  

[silverwind]

Can not reproduce. Try to update/reinstall.

[h1nk]

The issue was actually caused by GitHub-FixedHeader being used with this style (see related StylishThemes/GitHub-FixedHeader#16). Should I close this issue and reopen on there?

[xt0rted]

I just noticed this myself when the sticky header disappeared behind the sticky notification banner. Looks like github pushed a change out earlier that broke this. I'm not using the fixed header style, but I do have a custom one that functions similarly.

Not sure how similar the issues are between the styles but my fix was to add:

body:not(.min-width-lg) .notification-shelf + .application-main .gh-header-sticky.is-stuck,
body:not(.min-width-lg) .notification-shelf + .application-main .gh-header-sticky.is-stuck + .gh-header-shadow {
  margin-top: var(--offset) !important;
}

I think that css can be simplified, but I haven't looked into it too much since it fixed my issue.

[xt0rted]

@h1nk can you give this a try now? It looks like GitHub just pushed a fix out for the issue page sticky header so this might not be an issue anymore.

[the-j0k3r]

ping @h1nk

[h1nk]

@xt0rted & @the-j0k3r

That CSS rule along with the GitHub-Dark theme does not do the sticky header behavior like GitHub-FixedHeader for me. Not sure if I'm applying it wrong.

[xt0rted]

The fix I posted isn't needed now with GitHub's latest update. At least for my style.

[the-j0k3r]

Is it safe to close this?

[silverwind]

Guess so